4 Commits

Author SHA1 Message Date
KS Jannette
56d0c21b79 clean 2026-02-13 13:45:00 -05:00
S Jannette
37e81e773e Merge pull request #9 from kjannette/refactor4
more
2026-02-13 13:42:52 -05:00
KS Jannette
534da11217 more 2026-02-13 13:42:31 -05:00
S Jannette
2212755772 Merge pull request #8 from kjannette/refact3
cleanup
2026-02-13 13:35:29 -05:00
4 changed files with 27 additions and 12 deletions

View File

@@ -11,6 +11,6 @@ app.use('/v1/notes', router);
app.use((req, res) => { app.use((req, res) => {
res.status(404).json({ error: `Requested path is invalid or does not exist: ${req.method} ${req.originalUrl}` }); res.status(404).json({ error: `Requested path is invalid or does not exist: ${req.method} ${req.originalUrl}` });
}); });
export default app; export default app;

View File

@@ -3,7 +3,7 @@ import { readFile } from 'fs/promises';
import { clusterNotes } from '../services/clustering.service.js'; import { clusterNotes } from '../services/clustering.service.js';
const router = Router(); const router = Router();
const DATA_PATH = '../data/notes.json' const DATA_PATH = '../data/notes.json';
const loadNotes = async () => { const loadNotes = async () => {
const raw = await readFile(DATA_PATH, 'utf-8'); const raw = await readFile(DATA_PATH, 'utf-8');
@@ -15,7 +15,7 @@ router.get('/', async (req, res) => {
const notes = await loadNotes(); const notes = await loadNotes();
res.json(notes); res.json(notes);
} catch (err) { } catch (err) {
console.error(`Error loading notes: ${err}`) console.error(`Error loading notes: ${err}`);
res.status(500).json({ error: 'Failed to load notes' }); res.status(500).json({ error: 'Failed to load notes' });
} }
}); });
@@ -26,7 +26,7 @@ router.post('/cluster', async (req, res) => {
const clusters = await clusterNotes(notes); const clusters = await clusterNotes(notes);
res.json(clusters); res.json(clusters);
} catch (err) { } catch (err) {
console.error(`Clustering failed: ${err}` ) console.error(`Clustering failed: ${err}`);
res.status(500).json({ error: `Clustering failed: ${err}` }); res.status(500).json({ error: `Clustering failed: ${err}` });
} }
}); });

View File

@@ -40,6 +40,15 @@ export const clusterNotes = async (notes) => {
], ],
}); });
const raw = response.content[0].text; const textBlock = response?.content?.[0];
return JSON.parse(raw);
if (!textBlock || textBlock.type !== 'text' || typeof textBlock.text !== 'string') {
throw new Error('Unexpected response from LLM API: no text content returned');
}
try {
return JSON.parse(textBlock.text);
} catch {
throw new Error('LLM API returned non-JSON response');
}
}; };

View File

@@ -35,7 +35,7 @@ describe('clusterNotes service', () => {
it('should call Anthropic messages.create with the correct model', async () => { it('should call Anthropic messages.create with the correct model', async () => {
createMock.mockResolvedValue({ createMock.mockResolvedValue({
content: [{ text: JSON.stringify(MOCK_CLUSTERS) }], content: [{ type: 'text', text: JSON.stringify(MOCK_CLUSTERS) }],
}); });
await clusterNotes(MOCK_NOTES); await clusterNotes(MOCK_NOTES);
@@ -48,7 +48,7 @@ describe('clusterNotes service', () => {
it('should include all note texts in prompt sent to the LLM API', async () => { it('should include all note texts in prompt sent to the LLM API', async () => {
createMock.mockResolvedValue({ createMock.mockResolvedValue({
content: [{ text: JSON.stringify(MOCK_CLUSTERS) }], content: [{ type: 'text', text: JSON.stringify(MOCK_CLUSTERS) }],
}); });
await clusterNotes(MOCK_NOTES); await clusterNotes(MOCK_NOTES);
@@ -62,7 +62,7 @@ describe('clusterNotes service', () => {
it('should parse and return the clustered JSON from the API response', async () => { it('should parse and return the clustered JSON from the API response', async () => {
createMock.mockResolvedValue({ createMock.mockResolvedValue({
content: [{ text: JSON.stringify(MOCK_CLUSTERS) }], content: [{ type: 'text', text: JSON.stringify(MOCK_CLUSTERS) }],
}); });
const result = await clusterNotes(MOCK_NOTES); const result = await clusterNotes(MOCK_NOTES);
@@ -72,10 +72,16 @@ describe('clusterNotes service', () => {
it('should throw error when the API returns non-JSON', async () => { it('should throw error when the API returns non-JSON', async () => {
createMock.mockResolvedValue({ createMock.mockResolvedValue({
content: [{ text: 'An unknown error occured when generting structured response.' }], content: [{ type: 'text', text: 'An unknown error occured when generting structured response.' }],
}); });
await expect(clusterNotes(MOCK_NOTES)).rejects.toThrow(); await expect(clusterNotes(MOCK_NOTES)).rejects.toThrow('non-JSON response');
});
it('should throw error when the API response has no text content', async () => {
createMock.mockResolvedValue({ content: [] });
await expect(clusterNotes(MOCK_NOTES)).rejects.toThrow('no text content returned');
}); });
it('should throw error when Anthropic API authentication fails', async () => { it('should throw error when Anthropic API authentication fails', async () => {