more

cleanup

backend/services/clustering.service.js

@@ -40,6 +40,15 @@ export const clusterNotes = async (notes) => {
    ],
   });
 
-  const raw = response.content[0].text;
+  const textBlock = response?.content?.[0];
-  return JSON.parse(raw);
+  
+  if (!textBlock || textBlock.type !== 'text' || typeof textBlock.text !== 'string') {
+    throw new Error('Unexpected response from LLM API: no text content returned');
+  }
+
+  try {
+    return JSON.parse(textBlock.text);
+  } catch {
+    throw new Error('LLM API returned non-JSON response');
+  }
 };

backend/tests/Clustering.service.test.js

@@ -35,7 +35,7 @@ describe('clusterNotes service', () => {
 
   it('should call Anthropic messages.create with the correct model', async () => {
     createMock.mockResolvedValue({
-      content: [{ text: JSON.stringify(MOCK_CLUSTERS) }],
+      content: [{ type: 'text', text: JSON.stringify(MOCK_CLUSTERS) }],
     });
 
     await clusterNotes(MOCK_NOTES);
@@ -48,7 +48,7 @@ describe('clusterNotes service', () => {
 
   it('should include all note texts in prompt sent to the LLM API', async () => {
     createMock.mockResolvedValue({
-      content: [{ text: JSON.stringify(MOCK_CLUSTERS) }],
+      content: [{ type: 'text', text: JSON.stringify(MOCK_CLUSTERS) }],
     });
 
     await clusterNotes(MOCK_NOTES);
@@ -62,7 +62,7 @@ describe('clusterNotes service', () => {
 
   it('should parse and return the clustered JSON from the API response', async () => {
     createMock.mockResolvedValue({
-      content: [{ text: JSON.stringify(MOCK_CLUSTERS) }],
+      content: [{ type: 'text', text: JSON.stringify(MOCK_CLUSTERS) }],
     });
 
     const result = await clusterNotes(MOCK_NOTES);
@@ -72,10 +72,16 @@ describe('clusterNotes service', () => {
 
   it('should throw error when the API returns non-JSON', async () => {
     createMock.mockResolvedValue({
-      content: [{ text: 'An unknown error occured when generting structured response.' }],
+      content: [{ type: 'text', text: 'An unknown error occured when generting structured response.' }],
     });
 
-    await expect(clusterNotes(MOCK_NOTES)).rejects.toThrow();
+    await expect(clusterNotes(MOCK_NOTES)).rejects.toThrow('non-JSON response');
+  });
+
+  it('should throw error when the API response has no text content', async () => {
+    createMock.mockResolvedValue({ content: [] });
+
+    await expect(clusterNotes(MOCK_NOTES)).rejects.toThrow('no text content returned');
   });
 
   it('should throw error when Anthropic API authentication fails', async () => {